From ac8e072d9e63e672b5a998395f12ebdd3caed9ba Mon Sep 17 00:00:00 2001 From: Robert Raposa Date: Fri, 18 Aug 2023 12:23:50 -0400 Subject: [PATCH 1/2] docs: comment on EDXAPP_PRIVATE_REQUIREMENTS Add a note to clarify that EDXAPP_PRIVATE_REQUIREMENTS contains edx.org specific details, which is not ideal. The plan is to ultimately retire this repo according to the DEPR: https://github.com/openedx/public-engineering/issues/51 --- playbooks/roles/edxapp/defaults/main.yml | 3 +++ 1 file changed, 3 insertions(+) diff --git a/playbooks/roles/edxapp/defaults/main.yml b/playbooks/roles/edxapp/defaults/main.yml index d37724d75da..7e94ab84412 100644 --- a/playbooks/roles/edxapp/defaults/main.yml +++ b/playbooks/roles/edxapp/defaults/main.yml @@ -540,6 +540,9 @@ EDXAPP_EXTRA_REQUIREMENTS: [] # Example: # EDXAPP_PRIVATE_REQUIREMENTS: # - name: git+https://git.myproject.org/MyProject#egg=MyProject +# Note: This list contains edx.org specific dependencies, even thought this is +# a public repo. The plan is to phase this out along with the rest of this +# repo as part of the DEPR https://github.com/openedx/public-engineering/issues/51. EDXAPP_PRIVATE_REQUIREMENTS: # For Harvard courses: - name: xblock-problem-builder==5.1.3 From 1e8c97e000268c66e18b904ad5996d3a6211a6ee Mon Sep 17 00:00:00 2001 From: Robert Raposa Date: Mon, 21 Aug 2023 16:10:15 -0400 Subject: [PATCH 2/2] fixup! Update playbooks/roles/edxapp/defaults/main.yml Co-authored-by: Tim McCormack --- playbooks/roles/edxapp/defaults/main.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/playbooks/roles/edxapp/defaults/main.yml b/playbooks/roles/edxapp/defaults/main.yml index 7e94ab84412..5fc3802f1b0 100644 --- a/playbooks/roles/edxapp/defaults/main.yml +++ b/playbooks/roles/edxapp/defaults/main.yml @@ -540,7 +540,7 @@ EDXAPP_EXTRA_REQUIREMENTS: [] # Example: # EDXAPP_PRIVATE_REQUIREMENTS: # - name: git+https://git.myproject.org/MyProject#egg=MyProject -# Note: This list contains edx.org specific dependencies, even thought this is +# Note: This list contains edx.org specific dependencies, even though this is # a public repo. The plan is to phase this out along with the rest of this # repo as part of the DEPR https://github.com/openedx/public-engineering/issues/51. EDXAPP_PRIVATE_REQUIREMENTS: