-
Notifications
You must be signed in to change notification settings - Fork 424
WIP: Migrate Makefile calls to use compose plugin syntax #1128
Conversation
Thanks for the pull request, @VanDavv! Please note that it may take us up to several weeks or months to complete a review and merge your PR. Feel free to add as much of the following information to the ticket as you can:
All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here. This is currently a draft pull request. When it is ready for our review and all tests are green, click "Ready for Review", or remove "WIP" from the title, as appropriate. Once you've signed the CLA, please allow 1 business day for it to be processed. After this time, you can re-run the CLA check by editing the PR title. If the problem persists, you can tag the |
I've pushed the migrated provisioning scripts as I was successfully able to run |
Hi @VanDavv, just checking in to see if you already had a chance to sign the Contributor Agreement? |
Hey @VanDavv, just checking in to see if you're still planning to continue working on this PR? |
Hi @VanDavv, just a quick update that we're closing this PR now because it is stale. You may reopen this pull request, or open a new one, when you have time to come back to this work. |
@VanDavv Even though your pull request wasn’t merged, please take a moment to answer a two question survey so we can improve your experience in the future. |
1 similar comment
@VanDavv Even though your pull request wasn’t merged, please take a moment to answer a two question survey so we can improve your experience in the future. |
I've encountered an issue while trying to setup devstack on Debian 12 with fresh Docker installation.
Official docker installation instructions available here encourage users to install docker along with two plugins: Buildx and Compose
This allows developers to both utilize multi-arch builds with Buildx and to utilize the yaml-based approach in setting up containers with Compose
However, the way to use the docker compose, as installed by default, is by calling
Whereas the "old" way of using it, by installing a Python script, was by calling
This PR changes the calls from
docker-compose
todocker compose
in the Makefile of the devstack.People who might be affected negatively by this change are the developers who still use the docker compose installed outside the plugin. It can be mitigated by installing compose plugin by running
Without this PR, people who followed official Docker docs will have to install docker compose once again, as a Python script, to cover for the syntax change of the command
Here are my logs as I tried to use the Makefile with fresh docker and compose installation
With this PR, the command
make dev.pull.lms+frontend-app-learning
was completed successfullyEDIT
I have also updated different provisioning scripts to use the new non-hyphen syntax, but introducing those would require a lot of testing I believe. Will update this PR to be a draft PR and will test on my side whether there are any other implications of moving from
docker-compose
todocker compose
I've completed each of the following or determined they are not applicable: