Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: date config user ui change #2041

Merged
merged 6 commits into from
Sep 5, 2023
Merged

Conversation

jansenk
Copy link
Contributor

@jansenk jansenk commented Aug 30, 2023

TL;DR - Slightly change what the learners see when date config is set, and change how the dates are calculated

JIRA: AU-1356

Screenshot 2023-08-30 at 10 55 11 PM Screenshot 2023-08-30 at 10 59 21 PM Screenshot 2023-08-30 at 11 00 49 PM

Developer Checklist

Reviewer Checklist

Collectively, these should be completed by reviewers of this PR:

  • I've done a visual code review
  • I've tested the new functionality

FYI: @openedx/content-aurora

@jansenk jansenk requested a review from a team as a code owner August 30, 2023 22:02
@jansenk jansenk force-pushed the jkantor/change-displayed-dates branch from c6fe91c to 1c45a80 Compare August 30, 2023 22:02
@codecov
Copy link

codecov bot commented Aug 31, 2023

Codecov Report

Patch coverage: 98.16% and no project coverage change.

Comparison is base (94fd34b) 95.10% compared to head (71d4a56) 95.10%.

❗ Current head 71d4a56 differs from pull request most recent head 079bbe5. Consider uploading reports for the commit 079bbe5 to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #2041   +/-   ##
=======================================
  Coverage   95.10%   95.10%           
=======================================
  Files         158      158           
  Lines       17450    17485   +35     
  Branches     1625     1629    +4     
=======================================
+ Hits        16595    16629   +34     
- Misses        641      642    +1     
  Partials      214      214           
Flag Coverage Δ
unittests 95.10% <98.16%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
openassessment/xblock/test/test_submission.py 100.00% <ø> (ø)
openassessment/xblock/test/test_openassessment.py 99.63% <98.09%> (-0.37%) ⬇️
openassessment/xblock/openassessmentblock.py 90.49% <100.00%> (+0.17%) ⬆️
openassessment/xblock/submission_mixin.py 85.23% <100.00%> (+0.03%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jansenk jansenk force-pushed the jkantor/change-displayed-dates branch from 71d4a56 to 079bbe5 Compare August 31, 2023 22:10
Copy link
Contributor

@schenedx schenedx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@jansenk jansenk merged commit 6679c6a into master Sep 5, 2023
6 checks passed
@jansenk jansenk deleted the jkantor/change-displayed-dates branch September 5, 2023 15:39
BryanttV pushed a commit to eduNEXT/edx-ora2 that referenced this pull request Feb 6, 2024
* test: refactor assert_is_closed

* feat: change learner display and start and due date logic

* chore: translations

* fix: typo

* style: missing lank line

* test: fix tests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants