Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add enterprise users datatable #1341

Open
wants to merge 6 commits into
base: master
Choose a base branch
from
Open

Conversation

katrinan029
Copy link
Contributor

@katrinan029 katrinan029 commented Oct 23, 2024

Description

Adds a learners table to the modal for users to create a new group.
https://2u-internal.atlassian.net/browse/ENT-9465

UI

Screenshot 2024-10-31 at 11 48 52 AM

Screen.Recording.2024-10-31.at.11.46.15.AM.mov

Testing

  1. checkout this branch knguyen2/ent-9465 and visit link https://localhost.stage.edx.org:1991/alc-general/admin/people-management
  2. click on the 'Create group` button to navigate to the modal
  3. Verify that you can add and remove members after selecting each row.
  4. Verify that you can add and remove members by selecting the entire table.

For all changes

  • Ensure adequate tests are in place (or reviewed existing tests cover changes)

Only if submitting a visual change

  • Ensure to attach screenshots
  • Ensure to have UX team confirm screenshots

Copy link

codecov bot commented Oct 30, 2024

Codecov Report

Attention: Patch coverage is 58.82353% with 35 lines in your changes missing coverage. Please review.

Project coverage is 85.55%. Comparing base (4e72019) to head (ddc07ca).

Files with missing lines Patch % Lines
...ement/data/hooks/useEnterpriseLearnersTableData.js 9.09% 20 Missing ⚠️
...t/invite-modal/EnterpriseCustomerUserDatatable.jsx 85.71% 6 Missing ⚠️
...dit-management/invite-modal/InviteModalContent.jsx 57.14% 6 Missing ⚠️
src/data/services/LmsApiService.js 50.00% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1341      +/-   ##
==========================================
- Coverage   85.73%   85.55%   -0.19%     
==========================================
  Files         597      599       +2     
  Lines       13071    13150      +79     
  Branches     2766     2772       +6     
==========================================
+ Hits        11206    11250      +44     
- Misses       1800     1834      +34     
- Partials       65       66       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@katrinan029 katrinan029 marked this pull request as ready for review October 31, 2024 18:54
@katrinan029 katrinan029 requested a review from a team October 31, 2024 18:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant