-
Notifications
You must be signed in to change notification settings - Fork 204
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: upload codecov report as a separate workflow step #1476
fix: upload codecov report as a separate workflow step #1476
Conversation
Thanks for the pull request, @bradenmacdonald! What's next?Please work through the following steps to get your changes ready for engineering review: 🔘 Get product approvalIf you haven't already, check this list to see if your contribution needs to go through the product review process.
🔘 Provide contextTo help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:
🔘 Get a green buildIf one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green. 🔘 Let us know that your PR is ready for review:Who will review my changes?This repository is currently maintained by Where can I find more information?If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources:
When can I expect my changes to be merged?Our goal is to get community contributions seen and reviewed as efficiently as possible. However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:
💡 As a result it may take up to several weeks or months to complete a review and merge your PR. |
d73241f
to
f0775cd
Compare
f0775cd
to
5a7e403
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1476 +/- ##
=======================================
Coverage 87.74% 87.74%
=======================================
Files 310 310
Lines 5320 5320
Branches 1350 1350
=======================================
Hits 4668 4668
Misses 635 635
Partials 17 17 ☔ View full report in Codecov by Sentry. |
@feanil could I get your thoughts on this? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh yes please.. that would be really handy.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great idea! I think it would be great to do in other repos as well! My only concern is whether we have enough artifact space but that's not a blocker just something we'll keep an eye on.
Often, the
validate
workflow fails completely because of a temporary codecov error. To fix this, it's necessary to run the entire workflow all over again. This PR is my effort to improve the situation so that codecov uploading is a separate step that can be re-tried without needing to run the tests all over again.