Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Updated Xpert component to be lazy loaded #1498

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

rijuma
Copy link
Member

@rijuma rijuma commented Oct 18, 2024

Related issues: #1482

To improve bundle size we are lazy loading Xpert from frontend-lib-learning-assistant.

Bundlewatch before

PASS dist/108.js: 1.57KB < 1.27MB (gzip)
PASS dist/15.js: 995B < 1.27MB (gzip)
PASS dist/2.js: 772B < 1.27MB (gzip)
PASS dist/312.js: 1.25MB < 1.27MB (gzip)
PASS dist/329.js: 1.99KB < 1.27MB (gzip)
PASS dist/35.js: 1.01KB < 1.27MB (gzip)
PASS dist/550.js: 628B < 1.27MB (gzip)
PASS dist/750.js: 1.1KB < 1.27MB (gzip)
PASS dist/775.js: 858B < 1.27MB (gzip)
PASS dist/824.js: 1.65KB < 1.27MB (gzip)
PASS dist/885.js: 1.21KB < 1.27MB (gzip)
PASS dist/938.js: 663B < 1.27MB (gzip)
PASS dist/app.js: 94.3KB < 1.27MB (gzip)
PASS dist/runtime.js: 1.93KB < 1.27MB (gzip)

bundlewatch PASS
Everything is in check (+1.35MB, -0B)

Result breakdown at: https://ja2r7.app.goo.gl/5iYm4CybudWXSUSF6

Bundlewatch after

PASS dist/108.js: 1.57KB < 1.27MB (gzip)
PASS dist/15.js: 995B < 1.27MB (gzip)
PASS dist/2.js: 770B < 1.27MB (gzip)
PASS dist/312.js: 1.25MB < 1.27MB (gzip)
PASS dist/329.js: 1.99KB < 1.27MB (gzip)
PASS dist/35.js: 1.01KB < 1.27MB (gzip)
PASS dist/550.js: 627B < 1.27MB (gzip)
PASS dist/750.js: 1.11KB < 1.27MB (gzip)
PASS dist/775.js: 859B < 1.27MB (gzip)
PASS dist/824.js: 1.65KB < 1.27MB (gzip)
PASS dist/885.js: 1.21KB < 1.27MB (gzip)
PASS dist/938.js: 662B < 1.27MB (gzip)
PASS dist/app.js: 94.39KB < 1.27MB (gzip)
PASS dist/runtime.js: 1.93KB < 1.27MB (gzip)

bundlewatch PASS
Everything is in check (+1.35MB, -0B)

Result breakdown at: https://ja2r7.app.goo.gl/TXEwuYtUvirAdYFL8

There seem to be no evident improvement on the bundle size according to Bundlewatch.

Copy link

codecov bot commented Oct 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.69%. Comparing base (2a58ad2) to head (a01e19d).

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1498   +/-   ##
=======================================
  Coverage   88.69%   88.69%           
=======================================
  Files         312      312           
  Lines        5501     5502    +1     
  Branches     1365     1365           
=======================================
+ Hits         4879     4880    +1     
+ Misses        605      604    -1     
- Partials       17       18    +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@rijuma rijuma force-pushed the rijuma/xpert-lazy-load branch 2 times, most recently from f8fde7a to 842e2ac Compare October 18, 2024 14:41
@rijuma rijuma marked this pull request as ready for review October 18, 2024 14:53
@farhaanbukhsh
Copy link
Member

@rijuma There doesn't seem to be any changes in bundle size, am I missing something?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants