-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: pass sequenceId to api call #139
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #139 +/- ##
==========================================
+ Coverage 93.86% 94.05% +0.19%
==========================================
Files 68 68
Lines 1076 1077 +1
Branches 295 295
==========================================
+ Hits 1010 1013 +3
+ Misses 61 59 -2
Partials 5 5 ☔ View full report in Codecov by Sentry. |
this does just seem like a missed piece of code. One question tho, does this work correctly if the user is outside of the exam section? Like on the course outline or viewing a different piece of course content? |
I tried messing around with this on stage, going between the course view and the exam sequence view, which actually didn't cause any problems. In fact, I only saw the error in the exam sequence view, and interestingly, going between both views caused the problem not to happen. This is probably because these page-changes call Also, I determined that this was probably happening because of pollExamAttempt due to it always happening when the timer hit the :00 minute mark, meaning that this was going off every 60 seconds when pollAttempt is called. |
d267ff2
to
0c370ed
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
@ilee2u did we ever confirm this works when the user is outside of the particular exam section? I just tried a timed exam on stage and I get an error when viewing the outline with the timer running. |
Fix for https://2u-internal.atlassian.net/browse/COSMO-125
We seemed to forget to pass the sequenceId to the backend API call in thunks.js. I just added that back in, hopefully this should work on stage now.