Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: pass sequenceId to api call #139

Merged
merged 5 commits into from
Mar 11, 2024
Merged

fix: pass sequenceId to api call #139

merged 5 commits into from
Mar 11, 2024

Conversation

ilee2u
Copy link
Contributor

@ilee2u ilee2u commented Feb 22, 2024

Fix for https://2u-internal.atlassian.net/browse/COSMO-125

We seemed to forget to pass the sequenceId to the backend API call in thunks.js. I just added that back in, hopefully this should work on stage now.

Copy link

codecov bot commented Feb 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.05%. Comparing base (ab01003) to head (d4d5b84).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #139      +/-   ##
==========================================
+ Coverage   93.86%   94.05%   +0.19%     
==========================================
  Files          68       68              
  Lines        1076     1077       +1     
  Branches      295      295              
==========================================
+ Hits         1010     1013       +3     
+ Misses         61       59       -2     
  Partials        5        5              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@zacharis278
Copy link
Contributor

this does just seem like a missed piece of code. One question tho, does this work correctly if the user is outside of the exam section? Like on the course outline or viewing a different piece of course content?

@ilee2u
Copy link
Contributor Author

ilee2u commented Feb 22, 2024

this does just seem like a missed piece of code. One question tho, does this work correctly if the user is outside of the exam section? Like on the course outline or viewing a different piece of course content?

I tried messing around with this on stage, going between the course view and the exam sequence view, which actually didn't cause any problems. In fact, I only saw the error in the exam sequence view, and interestingly, going between both views caused the problem not to happen. This is probably because these page-changes call updateAttemptAfter, which works fine.

Also, I determined that this was probably happening because of pollExamAttempt due to it always happening when the timer hit the :00 minute mark, meaning that this was going off every 60 seconds when pollAttempt is called.

@zacharis278
Copy link
Contributor

@rijuma this might have been the cause of your bug as well.

@ilee2u have we tested those cases with this fix added? Wanna make sure the state we're pulling has the correct content id for the active attempt if this happens to get called when not in the right sequence.

@ilee2u ilee2u force-pushed the ilee2u/time_remaining_bugfix branch from d267ff2 to 0c370ed Compare March 8, 2024 21:51
Copy link
Contributor

@schenedx schenedx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@ilee2u ilee2u merged commit 52826e0 into main Mar 11, 2024
8 checks passed
@ilee2u ilee2u deleted the ilee2u/time_remaining_bugfix branch March 11, 2024 17:30
@zacharis278
Copy link
Contributor

@ilee2u did we ever confirm this works when the user is outside of the particular exam section? I just tried a timed exam on stage and I get an error when viewing the outline with the timer running.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants