Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

initialize() needs to abort for anonymous users if requireAuthenticatedUser is true #12

Open
davidjoy opened this issue Nov 21, 2019 · 0 comments
Open

initialize() needs to abort for anonymous users if requireAuthenticatedUser is true #12

davidjoy opened this issue Nov 21, 2019 · 0 comments

Comments

@davidjoy
Copy link
Contributor

Currently if requireAuthenticatedUser is true and the user is anonymous, we begin the login redirect process but don't actually abort initialization. Application code that depends on there being an authenticated user will then have unexpected behavior, most likely causing a flash of an error page prior to redirecting to login, which isn't a great experience.
brian-smith-tcril pushed a commit to brian-smith-tcril/frontend-platform that referenced this issue Jan 6, 2023
@robrap
Merge pull request openedx#12 from edx/robrap/ARCH-379-get-user-id
cdb5436 
feat(authentication): add userId and drop email
brian-smith-tcril pushed a commit to brian-smith-tcril/frontend-platform that referenced this issue Jan 6, 2023
feat: handle rtl with attribute only (openedx#12)
7653376 
BREAKING CHANGE: This package will no longer handle toggling rtl css on or off. Prefer to use a single file with rules scoped on [dir='rtl'] or [dir='ltr']
brian-smith-tcril pushed a commit to brian-smith-tcril/frontend-platform that referenced this issue Jan 6, 2023
feat: add custom attributes to logInfo (openedx#12)
b4b2340
brian-smith-tcril pushed a commit to brian-smith-tcril/frontend-platform that referenced this issue Jan 6, 2023
@davidjoy
fix: updating to frontend-auth 7 (openedx#12)
eaa1d91
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@davidjoy