Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Don't merge transifex bot pull requests unless it passes the tests #1003

Open
OmarIthawi opened this issue Sep 9, 2023 · 2 comments
Open
Assignees

Comments

@OmarIthawi
Copy link
Member

OmarIthawi commented Sep 9, 2023

Description

Now we have the validate-translation-files.yml workflow we should block the Transifex Bot from merging broken translations.

This should be configured in the GitHub repository settings even if it causes a backlog of pull requests to keep waiting.

Example of unwanted pull requests:

@OmarIthawi
Copy link
Member Author

@brian-smith-tcril I've assigned you since I'm not an admin to the repository.

@brian-smith-tcril
Copy link
Contributor

I added validate-po-files as a required status check for the branch protection rules on main. I'll leave this open until we verify it's working as intended.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants