Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: include message description in the transifex_input.json file #2065

Open
OmarIthawi opened this issue Oct 27, 2023 · 1 comment
Open
Labels
translations-request Requests for the WG regarding issues with translations.

Comments

@OmarIthawi
Copy link
Member

OmarIthawi commented Oct 27, 2023

Description

developer_message in translations files are useful and provides context for translators in Transifex. However, in most MFEs it's gets discarded.

Bad example: frontend-app-learning

Most repositories provides no developer_message e.g. Learning MFE:

"learning.accessExpiration.deadline": "Upgrade by {date} to get unlimited access to the course as long as it exists on the site.",
"learning.accessExpiration.header": "Audit Access Expires {date}",
"learning.accessExpiration.body": "You lose all access to this course, including your progress, on {date}.",
"instructorToolbar.pageBanner.courseHasExpired": "This learner no longer has access to this course. Their access expired on {date}.",
"learning.accessExpiration.upgradeNow": "Upgrade now",

The transifex_input.json is extract with the following command:

Good example: Paragon

Paragon transifex_input.json includes developer_message which provides helpful context for translators:

{
"dropzone.Dropzone.invalidSizeLessError": {
"developer_comment": "A message shown when a file with less than minimum allowed size is being uploaded in Dropzone.",
"string": "File must be larger than {size}."
},
"dropzone.Dropzone.invalidSizeMoreError": {
"developer_comment": "A message shown when a file with more than maximum allowed size is being uploaded in Dropzone.",
"string": "File must be less than {size}."
},
"dropzone.Dropzone.invalidType": {
"developer_comment": "A message shown when a file with wrong MIME type is being uploaded.",
"string": "The file type must be {count, plural, one {{typeString} file} other {one of {typeString} files}}."
},

Paragon uses the following scripts:

@OmarIthawi OmarIthawi added the translations-request Requests for the WG regarding issues with translations. label Oct 27, 2023
@openedx-workflow-automation
Copy link

Thank you for your report! The Translations WG has been notified and will take a look as soon as they can.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
translations-request Requests for the WG regarding issues with translations.
Projects
None yet
Development

No branches or pull requests

1 participant