Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Define types for Paragon exports #1964

Open
adamstankiewicz opened this issue Jan 27, 2023 · 2 comments
Open

Define types for Paragon exports #1964

adamstankiewicz opened this issue Jan 27, 2023 · 2 comments
Assignees
Labels

Comments

@adamstankiewicz
Copy link
Member

adamstankiewicz commented Jan 27, 2023

Through #1962, it was discovered that we need to define types for Paragon's exports defined in src/index.js.

In the short term, we'd like to define these types in the Paragon repository itself.

An example related issue from the perspective of a consumer:

[engineer] who is trying to bring TypeScript into frontend-app-admin-portal ran into issue where TypeScript was complaining that Paragon's Button component didn't have types defined and would need to define them locally in the application to get around it.

@PKulkoRaccoonGang
Copy link
Contributor

Pull Request: #2177

@monteri
Copy link
Contributor

monteri commented Aug 21, 2023

Reacreated PR: #2566

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: In review
Development

Successfully merging a pull request may close this issue.

3 participants