Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove react-bootstrap dependency from Form component #2485

Open
3 tasks
viktorrusakov opened this issue Jul 28, 2023 · 0 comments
Open
3 tasks

Remove react-bootstrap dependency from Form component #2485

viktorrusakov opened this issue Jul 28, 2023 · 0 comments
Labels
code health Proactive technical investment via refactorings, removals, etc. engineering Engineering enhancement Relates to new features or improvements to existing features

Comments

@viktorrusakov
Copy link
Contributor

This issue has the same rationale as #2484, i.e. we extend Form component when we really shouldn't be doing that anymore. However, this task is a bit more complicated as some of the consumers use react-bootstrap's Form API instead of Paragon's, we'll need to address that too in order not to make a breaking change. Judging by the list of compound components that react-bootstrap's Form has, Paragon currently does not provide the following

  • Form.Row, which is used by consumers and is present on our docs site, we'll need to implement our own version of this component
  • Form.Check, which is replaced by our Form.Checkbox, but is still available and used by consumers, we'll need to updated consuming MFEs to use Form.Checkbox instead
  • Form.File, I don't see it being used by consumers and it is not present on our docs site, should be safe to remove

Tasks

@viktorrusakov viktorrusakov added enhancement Relates to new features or improvements to existing features code health Proactive technical investment via refactorings, removals, etc. engineering Engineering labels Jul 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
code health Proactive technical investment via refactorings, removals, etc. engineering Engineering enhancement Relates to new features or improvements to existing features
Projects
Status: Backlog
Development

No branches or pull requests

1 participant