-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Product Pull Request] bug: Profile image on user posts #314
Comments
Thanks for your submission, @openedx/open-edx-project-managers will review shortly. |
There are a lot of open product questions that need to be addressed here.
|
The user's profile image absence seemed to be a bug (while testing the Palm release) for us because it was present in the Olive release. I just researched the feature changes history and found this PR where I believe the image was replaced with the placeholder. Unfortunately, I can't view the related Jira ticket and the PR description is too poor, so I don't know the motivation behind that change. I think we could just close our PRs if our suggestion that this is a bug was wrong. |
Let me do some testing on our new Quince branch. |
@jmakowski1123 Has this been reviewed in Quince? I've labelled this as a "bug" until we know more. |
Hi all - any update on this one? |
Hi Are there any updates on the issue? |
I've looked at a bunch of live courses on edx.org, and they all have generic profile images. @ayub02 , can you confirm that this is actually the intended behavior for the discussion forums? |
Hi @ayub02 and @jmakowski1123 - just checking in on this! |
Hi @mphilbrick211 ! Here's what i shared with Jenna. Please let me know what you think: |
Thanks @ayub02 . @dyudyunov Can this be developed behind a waffle flag? We can turn it on by default in the community release. If so, this has product approval. |
I think we could gate it using either a waffle flag on the backend or an additional config in the MFE env. The first option with the waffle flag seems better to me. We'll plan further work on it |
Waffle flag sounds good to me. I'm ok with it enabled by default. |
Hi @dyudyunov - just checking to see if there's an update on this one? |
@vladislavkeblysh please update your PRs according to the discussion results - add an option to toggle profile image displaying (default - is to display user profile image). It could be either a waffle flag or a new setting in the MFE env (the waffle flag - is a preferred solution)
|
For Contributing Author:
This is the Primary Product Ticket for the following community contribution: New feature that will allow course instructors to manage certificates.
Checklist prior to undergoing Product Review:
The following information is required in order for Product Managers to be able to review your pull request:
Only if necessary:
Related PRs
For Product Manager doing the review:
What criteria should be analyzed from Product to approve a PR?
The text was updated successfully, but these errors were encountered: