-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improvements to the Limited Staff role experience #361
Comments
Thanks for your submission, @openedx/open-edx-project-managers will review shortly. |
@arbrandes @brian-smith-tcril Could you please add any technical requirements you'd like to see here? |
In order to be able to fully test the Limited Staff role UX, I'd want to know:
Answers to the previous questions would help inform my thoughts on this from a technical implementation perspective:
|
Limited Staff should not have access to any of the Studio pages in the course-authoring MFE. @0x29a as the contributing author for this role, is there anything you'd add here? openedx/edx-platform#32570 |
No, @jmakowski1123, this description is correct. cc @Agrendalath |
@jmakowski1123 It looks like the following PRs are providing a partial implementation of this proposal:
Could you please have a look at those and let us know what the next steps are from the product perspective? |
@jmakowski1123 Could you please have a look at the comment above and let us know how to proceed? (Happy to ping someone else from the product working group if you'd prefer. Let me know.) |
@itsjeyd I stand to be corrected, but I don't think that #1436: hide studio button for limited staff would need additional product review considering @jmakowski1123 has already "approved" this change simply by creating the current issue:
However, something that would need product input, is the messaging described in the following comment, but I imagine this would be covered in a separate issue.
Let me know if there's anything I can do to help move this along. |
@ali-hugo That's helpful input, thank you! @0x29a Can you confirm that openedx/frontend-app-learning#1436 and openedx/edx-platform#35313 address this need:
... and nothing else? |
@itsjeyd, can confirm. These two PRs just remove the button in question for Limited Staff and do nothing else. |
@0x29a @itsjeyd It was just confirmed in the Core Product Working Group meeting that openedx/frontend-app-learning#1436 and openedx/edx-platform#35313 can be merged! 🚀 We'll keep the current ticket (#361) open to work on improving the user experience when someone visits a Studio page to which they don't have access. We need a more user-friendly solution than 403 error that is currently shown. @0x29a, could you please send a screenshot of the 403 message so I can take a look? |
Thanks @ali-hugo! I added the Regarding the 403 message, do we have an internal ticket for working on that? We can't add it to the scope of the ticket that prompted the creation of openedx/frontend-app-learning#1436 and openedx/edx-platform#35313 at this time. |
@itsjeyd Not yet. I am out of hours for this month, so will only be able to work on this next month. I will create an internal ticket then. |
@ali-hugo, here it is: |
@0x29a Thank you! |
Sounds good. @0x29a If you end up spending more time helping out here, please log that time on the ticket that Ali's going to create. Since the 403 message is out of scope for the original ticket, we can't use that ticket to log time spent on the 403 message. |
@jmakowski1123 @0x29a I've been thinking about how to improve the 403 messaging when someone with the Limited Staff role visits a Studio URL. Please let me know what you think of the two options below: You'll notice that I've included a "back to safety" link to the LMS (since the Limited Staff user doesn't have access to any Studio pages). For other types of users, I imagine it would be more helpful to link them to the Studio Home. Is it too complicated to show different 403's for different user types? Thanks for your help! |
#2 is better from my opinion, it's more standard a message. |
The Limited Staff role needs some improvements to the user experience.
Currently, when a user with the Limited Staff role lands on a Studio Page in the new course-authoring MFE, they are blocked by a 403 error message, which contains json fields and is difficult to interpret. Minimally, the messaging could be improved to explain that the user is not granted access to Studio.
An enhancement can be made in the Studio experience such that users with this role do not see the "View this course in Studio" button. This will greatly reduce the chance of users trying to access parts of the platform that they don't have access to.
The text was updated successfully, but these errors were encountered: