Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

External uses should be checked only against 'cas' provider #78

Open
claudiu-cristea opened this issue Jun 3, 2019 · 0 comments
Open
Labels
bug Something isn't working

Comments

@claudiu-cristea
Copy link
Contributor

claudiu-cristea commented Jun 3, 2019

In \Drupal\oe_authentication\Access\ExternalUserAccessCheck::access() there is this piece of code:

if ($this->authMap->getAll($account->id()) === []) {
  return AccessResult::allowed();
}

Using ::getAll() here is wrong because on a system might offer support for multiple external authentication authorities (social media, Github, OpenID, etc.)

Even if limiting the access to those routes could be useful when using other provider/authority, this module should not make assumptions on behalf them.

@brummbar brummbar added the bug Something isn't working label Jun 3, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants