Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Scss compiling doesn't work with npm #1232

Open
mibocs opened this issue Jan 12, 2023 · 1 comment
Open

Scss compiling doesn't work with npm #1232

mibocs opened this issue Jan 12, 2023 · 1 comment

Comments

@mibocs
Copy link

mibocs commented Jan 12, 2023

Version of oe_theme: 3.0.0
Project: https://github.com/ec-europa/just-ejustice-reference

The scss compiling doesn't work in oe_theme by default. The documentation supposes that the Node is installed in the developer's Docker instance, so there is nothing about which exact version of Node and NPM should be used. There is just the following info about Node:

In order to fetch the required code you'll need to have Node.js (>= 8) installed locally.

The Docker of Cloud 9 has Node installed though but we don't have Node in our local Docker. It is an other question why there are discrepancies between Cloud 9 Docker and our local Docker.

I had to fix a few things to make "npm run watch" work:

  • I had to downgrade my local Node and NPM to the following versions:
    node --version
    v14.21.2

    npm --ver
    [email protected]

    So the scss compiling doesn't work with all Node versions and usually especially with the latest ones even though the documentation says we just need "Node.js (>= 8)".

  • I had to upgrade components in package.json. It is not how we should fix this here though. This should be inline with oe_theme and if something has to be fixed then it has to be fixed in oe_theme.
    package_json

  • I had to fix ecl-builder.config.js:
    stylelintrc_json

So normally this should work if we keep our theme inline with base theme i.e with oe_theme but this doesn't seem to work there either(maybe because our oe_theme is not the latest one). I mean i tested oe_theme too but couldn't compile scss.

Could you please check this issue? Thanks

@ademarco
Copy link
Member

Builds are only supposed to work via the provided docker-compose.yml file, but I understand that the documentation is wrong, in any case. We should upgrade the whole build script, since it's quite outdated, but we will always require the usage of the Docker Compose node image. So my suggestion would be to use the same node service in your local docker-compose.yml, for now, until we will update this.

In any case: what node version you ran this on, when it wasn't working, and what was the error you got?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants