Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

missing core/once to libraries.yml #1313

Open
john4190 opened this issue Aug 30, 2023 · 4 comments
Open

missing core/once to libraries.yml #1313

john4190 opened this issue Aug 30, 2023 · 4 comments
Labels

Comments

@john4190
Copy link

in order to fully support js asset injection i strongly suggest to include core/once in theme dependencies

@brummbar
Copy link
Contributor

brummbar commented Sep 6, 2023

Js assets should be libraries, and they can declare their dependencies.

@brummbar brummbar closed this as completed Sep 6, 2023
@brummbar
Copy link
Contributor

brummbar commented Sep 6, 2023

... unless you mean in the current libraries we have. On that I agree :)

@brummbar brummbar reopened this Sep 6, 2023
@brummbar brummbar added the bug label Sep 6, 2023
@john4190
Copy link
Author

john4190 commented Sep 6, 2023 via email

@john4190
Copy link
Author

john4190 commented Sep 6, 2023

anyway yes having core/once helps you as well if you have to handle events in the drupal way and keep everything compatible with drupal 10

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants