-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
missing core/once to libraries.yml #1313
Labels
Comments
Js assets should be libraries, and they can declare their dependencies. |
... unless you mean in the current libraries we have. On that I agree :) |
yes but i am not trying to create a new module, i am trying to exploit ECL
components in order to make search page as compliant as possible to
European union guidelines. Moreover fortunately there are modules for
injecting small pieces of javascript without creating a new module and
without disrupting everything
Il giorno mer 6 set 2023 alle ore 15:53 Francesco ***@***.***>
ha scritto:
… Js assets should be libraries, and they can declare their dependencies.
—
Reply to this email directly, view it on GitHub
<#1313 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AEYD4JV4O4TLYUBGYUWQG3LXZB547ANCNFSM6AAAAAA4EEVPJ4>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
anyway yes having core/once helps you as well if you have to handle events in the drupal way and keep everything compatible with drupal 10 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
in order to fully support js asset injection i strongly suggest to include core/once in theme dependencies
The text was updated successfully, but these errors were encountered: