Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Duplicate title for social block #135

Open
golddragon007 opened this issue Aug 28, 2020 · 1 comment
Open

Duplicate title for social block #135

golddragon007 opened this issue Aug 28, 2020 · 1 comment

Comments

@golddragon007
Copy link

In the following location, there shouldn't be title set: https://github.com/openeuropa/oe_webtools/blob/master/modules/oe_webtools_social_share/src/Plugin/Block/SocialShareBlock.php#L48
In the block build section, only the block content needs to be set, and the title is provided by default by Drupal from the structure | block interface where we placing blocks. Otherwise, we will have two titles and it won't be consistent where we need or how we need to overwrite now the title. The admin_label annotation is the default value when somebody creating a title.

@Joaoeduardoramos
Copy link

I can confirm the same issue, i think that should be the admin_label if it's intended to be the block title or change it to let that value to be configured.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants