Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update better_exposed_filters module #294

Open
msnassar opened this issue Jul 16, 2024 · 2 comments
Open

Update better_exposed_filters module #294

msnassar opened this issue Jul 16, 2024 · 2 comments
Labels
bug Something isn't working contribution welcome Any contribution to fix this issue is welcome

Comments

@msnassar
Copy link

msnassar commented Jul 16, 2024

  • Update better_exposed_filters module.
  • Fix return type compatibility:
    Fatal error: Declaration of Drupal\oe_whitelabel_helper\Plugin\better_exposed_filters\sort\FloatEndSortWidget::exposedFormAlter(array &$form, Drupal\Core\Form\FormStateInterface $form_state) must be compatible with Drupal\better_exposed_filters\Plugin\better_exposed_filters\sort\DefaultWidget::exposedFormAlter(array &$form, Drupal\Core\Form\FormStateInterface $form_state): void in /var/www/html/websites/ucpkn/dev/web/themes/contrib/oe_whitelabel/modules/oe_whitelabel_helper/src/Plugin/better_exposed_filters/sort/FloatEndSortWidget.php on line 23
@drishu drishu added bug Something isn't working contribution welcome Any contribution to fix this issue is welcome labels Aug 19, 2024
@drishu
Copy link
Contributor

drishu commented Aug 19, 2024

A contribution would be welcome

@libetho
Copy link

libetho commented Nov 4, 2024

@msnassar , @drishu
I had same issue on ERA website after updating to better exposed filters 7
This is my fix: #325
Regards

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working contribution welcome Any contribution to fix this issue is welcome
Projects
None yet
Development

No branches or pull requests

3 participants