Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Zero can't be formatted #139

Open
firedev opened this issue Mar 23, 2016 · 4 comments · May be fixed by #219
Open

Zero can't be formatted #139

firedev opened this issue Mar 23, 2016 · 4 comments · May be fixed by #219

Comments

@firedev
Copy link

firedev commented Mar 23, 2016 

const accounting = require('accounting')
const value = 0

accounting.formatMoney(
  value, {
    symbol: '%',
    format: {
      pos: '%v%s',
    }})

Expected:

0%

Actual:

node_modules/accounting/accounting.js:307
        return useFormat.replace('%s', opts.symbol).replace('%v', formatNumber(Math.abs(number), checkPrecision(opts.precision), opts.thousand, opts.decimal));
                        ^

TypeError: Cannot read property 'replace' of undefined
    at Object.lib.formatMoney (/Users/pain/Sites/sr/apps/node_modules/accounting/accounting.js:307:19)
    at Object.<anonymous> (/Users/pain/Sites/sr/apps/src/test.js:4:12)
    at Module._compile (module.js:413:34)
    at Object.Module._extensions..js (module.js:422:10)
    at Module.load (module.js:357:32)
    at Function.Module._load (module.js:314:12)
    at Function.Module.runMain (module.js:447:10)
    at startup (node.js:142:18)
    at node.js:939:3

Works if the value is not 0
@in15
Copy link

in15 commented Jun 23, 2016

Hey @firedev. Were you able to find a solution? Running into something similar now

@goferito
Copy link

+1 here. I had to handle 0 to avoid formatting it with this library. I think the solution is pretty easy though, but maintainers don't seem to accept PRs anymore.

@firedev
Copy link
Author

firedev commented Dec 13, 2016 •
edited
Loading

Hey @in15, sorry, I just handle zeros manually.

@garmr
Copy link

garmr commented Nov 14, 2017 •
edited
Loading

Sorry to resurect old thread but I've just ran into this issue.
After reviewing the code it appears that zero needs its own special format to avoid this issue.

accounting.settings = {
    currency: {
        symbol : "€",   // default currency symbol is '$'
        format: {
            pos : "%v&nbsp;%s",
            zero : "%v&nbsp;%s"
        }, // controls output: %s = symbol, %v = value/number (can be object: see below)
        decimal : ",",  // decimal point separator
        thousand: " ",  // thousands separator
        precision : 2,   // decimal places
    },
    number: {
        precision : 0,  // default precision on numbers is 0
        thousand: " ",
        decimal : ","
    }
};

please note the zero : "%v&nbsp;%s" index under format.

This solved this issue at least in my specific case.

This was referenced Sep 28, 2020
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Allow optional fields on currency format aaron-hardin/accounting.js
5 participants
@firedev @garmr @goferito @in15 and others