Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

README client should call fga_client instead of api_instance #25

Closed
3 tasks
Tracked by #126
adriantam opened this issue Jun 9, 2023 · 1 comment · Fixed by #32
Closed
3 tasks
Tracked by #126

README client should call fga_client instead of api_instance #25

adriantam opened this issue Jun 9, 2023 · 1 comment · Fixed by #32
Assignees
Labels
documentation Improvements or additions to documentation good first issue Good for newcomers

Comments

@adriantam
Copy link
Member

adriantam commented Jun 9, 2023

Currently, the (README file)[https://github.com/openfga/python-sdk/blob/main/README.md] is incorrect in several places where api_instance is used instead of fga_client.

The sample code for

uses api_instance instead of fga_client. The purpose of this issue is to change all these instances to use fga_client instead.

Ideally, we will also fix the SDK generator so that newly generated python SDKs will have the corresponding changes. This is tracked as openfga/sdk-generator#126. However, if that is difficult to do, simply focusing on the Python SDK side https://github.com/openfga/python-sdk/blob/main/README.md will help us as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation good first issue Good for newcomers
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants