Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[All SDKs] Drop StoreId from the OpenFgaApi configuration interface #118

Open
3 of 4 tasks
rhamzeh opened this issue May 22, 2023 · 0 comments
Open
3 of 4 tasks

[All SDKs] Drop StoreId from the OpenFgaApi configuration interface #118

rhamzeh opened this issue May 22, 2023 · 0 comments
Assignees
@evansims
Labels
breaking dotnet-sdk Affects the C#/DotNet SDK enhancement New feature or request go-sdk Affects the Go SDK js-sdk Affects the JavaScript SDK python-sdk Affects the Python SDK

Comments

@rhamzeh
Copy link
Member

rhamzeh commented May 22, 2023 •
edited
Loading

The OpenFgaApi methods that need a storeId should start accepting StoreId as the first parameter.

This would allow us to drop the custom patches we have (e.g. JS SDK here), and allow users to target multiple stores with the same client if they wish.
@rhamzeh rhamzeh added go-sdk Affects the Go SDK dotnet-sdk Affects the C#/DotNet SDK js-sdk Affects the JavaScript SDK python-sdk Affects the Python SDK breaking enhancement New feature or request labels May 22, 2023
@rhamzeh rhamzeh moved this to Backlog in SDKs and Tooling Jan 22, 2024
@rhamzeh rhamzeh mentioned this issue Feb 6, 2024
Merged
4 tasks
@jimmyjames jimmyjames mentioned this issue May 21, 2024
Merged
4 tasks
This was referenced May 29, 2024
Merged
Merged
@rhamzeh rhamzeh mentioned this issue Jun 10, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@evansims evansims

Labels
breaking dotnet-sdk Affects the C#/DotNet SDK enhancement New feature or request go-sdk Affects the Go SDK js-sdk Affects the JavaScript SDK python-sdk Affects the Python SDK
Projects
SDKs and Tooling
Status: Backlog
Milestone
No milestone
Development

No branches or pull requests
3 participants
@evansims @jimmyjames @rhamzeh