Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement generalized get method #7

Open
kael-shipman opened this issue Dec 2, 2017 · 0 comments
Open

Implement generalized get method #7

kael-shipman opened this issue Dec 2, 2017 · 0 comments

Comments

@kael-shipman
Copy link
Member

kael-shipman commented Dec 2, 2017

Currently the get method is inelegant at best. It first prepares a SQLQuery, then executes the query, sometimes prepares the result, converts the result to jsonapi format, then inflates the result.

It would be nice to organize this method into an Algorithm pattern that utilizes hooks along the way to allow subclasses to alter the results, rather than having to rewrite the method every time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant