Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce knowledge in Hunger Games to help contributors make educated answers #253

Open
6 tasks
Tracked by #37
teolemon opened this issue Oct 5, 2022 · 5 comments
Open
6 tasks
Tracked by #37

Comments

@teolemon
Copy link
Member

teolemon commented Oct 5, 2022

What

Part of

@raphael0202
Copy link
Contributor

raphael0202 commented Oct 10, 2022

As of the image of the label, we already provide in Robotoff API the logo image under the image_url field:

{
	"barcode": "8001090177292",
	"type": "add-binary",
	"value": "AB Agriculture Biologique",
	"question": "Le produit a-t-il ce label ?",
	"insight_id": "c4ef22c0-3da2-4590-9fb2-a898eb7da3c9",
	"insight_type": "label",
	"value_tag": "fr:ab-agriculture-biologique",
	"image_url": "https://https://static.openfoodfacts.org/images/lang/fr/labels/ab-agriculture-biologique.74x90.svg",
	"source_image_url": "https://static.openfoodfacts.org/images/products/800/109/017/7292/1.400.jpg"
}

The name is poorly chosen, I was thinking of renaming it reference_image_url. We don't support a lot of labels right now, but it can be expanded (by the way I haven't seen the label image URL in the label taxonomy, where is it stored?)

I would keep all these features on Robotoff to avoid duplicating this on each distribution channel (mobile/web/Hunger Games)

@raphael0202
Copy link
Contributor

I've renamed the image_url field into the more meaningful name ref_image_url.
See https://robotoff.openfoodfacts.org/api/v1/questions/popular?insight_types=label&value_tag=en:eu-organic&count=1

And I've added many label logos as well. This can be used to display reference images.

@teolemon
Copy link
Member Author

@teolemon
Copy link
Member Author

teolemon commented Aug 29, 2023

@raphael0202 @alexfauquette how about hardcoding a few example based on tag value

if label (en:eu-agriculture,en:eu-non-eu-agriculture): help_tip:"Be particularly careful while validating, since the detection might have been incorrect due to a cropped image. Check whether the value is EU Agriculture, or EU/Non EU Agriculture. If you are in doubt, skip this question"

@alexfauquette
Copy link
Member

Sound doable, it will simplify their translation with crowding

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: To Discuss & Validate
Status: 📋 Backlog
Development

No branches or pull requests

3 participants