Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

de-selecting a facet should trigger the "search" text on button #206

Open
alexgarel opened this issue Jun 29, 2024 · 2 comments
Open

de-selecting a facet should trigger the "search" text on button #206

alexgarel opened this issue Jun 29, 2024 · 2 comments
Assignees

Comments

@alexgarel
Copy link
Member

If we de-select a facet, the button does not change text to advertise we need to relaunch search.

We have to have an event (facet unselected ?) and handle it, as we do for facet_selected.

@alexgarel alexgarel added the 🐛 Bug Something isn't working label Jun 29, 2024
@github-project-automation github-project-automation bot moved this to Backlog (ready for dev) in 🔎 Search-a-licious Jun 29, 2024
@alexgarel alexgarel moved this from Backlog (ready for dev) to Todo (selected) in 🔎 Search-a-licious Jul 4, 2024
@Kout95
Copy link
Collaborator

Kout95 commented Jul 8, 2024

It do if the search is different from current one.
You have two cases :

  • if you select facet and unselect after : it will not show search because requested params do not change
  • If you select facet => search => unselect the button will be show

Image

@alexgarel
Copy link
Member Author

if you select facet and unselect after : it will not show search because requested params do not change

Yes, that's fine…

@teolemon teolemon removed the 🐛 Bug Something isn't working label Oct 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Todo (selected)
Development

No branches or pull requests

3 participants