Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support loading both Skew-T and Altitude data #273

Open
savelov opened this issue Feb 26, 2021 · 2 comments
Open

support loading both Skew-T and Altitude data #273

savelov opened this issue Feb 26, 2021 · 2 comments

Comments

@savelov
Copy link
Contributor

savelov commented Feb 26, 2021

I noticed that in https://github.com/opengribs/XyGrib/blob/master/src/DialogLoadGRIB.cpp#L167 it is not allowed to load both Skew-T data and altitude data, however allowing that enables Skew-T profiles down to ground (see attached screenshots)
altutude_without_skewt
skewt_plus_altitude
I remember using ZyGrib with both, hence suggesting to remove this restriction. I have tried commenting out the logic in source code, it works correctly, however increasing the GRIB file size - may be this is the reason for restricting it?
Please advise

@savelov
Copy link
Contributor Author

savelov commented Mar 13, 2021

I have made a fix for it in savelov@4a36f23
but not sure the reason why this was originally disabled - may be due to performance issues?

@norulz
Copy link
Collaborator

norulz commented Jan 16, 2022

It was a performance issue.
There are other performance control mechanisms on the server now so I will check about removing this.
David

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants