Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Windows instructions #10

Open
bretwalker opened this issue Aug 23, 2019 · 4 comments
Open

Windows instructions #10

bretwalker opened this issue Aug 23, 2019 · 4 comments
Labels
documentation Improvements or additions to documentation good first issue Good for newcomers

Comments

@bretwalker
Copy link
Member

I'm not sure if the README instructions work on Windows.

I'm hoping with git bash and Docker installed, they will.

If someone can test and update the README appropriately, that would be great!

@bretwalker bretwalker added documentation Improvements or additions to documentation good first issue Good for newcomers labels Aug 23, 2019
@kenwrites
Copy link
Contributor

Working on this issue, and having some trouble. I'm relatively new to Docker, so that might be the problem. After cloning the repo, what docker commands would you run before you hit the 'make build' step?

I tried a number of things and so far have only run into problems:

  1. docker build . (seemed to execute fine)

  2. docker tag [image] rentersrights (fine)

  3. docker run rentersrights "make build" : Error: bin\docker.exe: Error response from daemon: OCI runtime create failed: container_linux.go:345: starting container process caused "exec: "make build": executable file not found in $PATH": unknown.

  4. docker container create rentersrights (fine)

  5. docker container start [container] : Fine, but container exits immediately, so I'm unable to exec "make build" against it.

@kenwrites
Copy link
Contributor

One more note: not sure if this was intended, but I tried running make begin from Windows Bash and got this error:

make: docker-compose: Command not found
Makefile:57: recipe for target 'build' failed
make: *** [build] Error 127

@bretwalker
Copy link
Member Author

Thanks for picking this up, @kenwrites!

With the makefile, you shouldn’t need to run any rocker commands manually.

It looks like docker-compose may not be installed on your machine. I think it’s supposed to be installed with the standard Docker Desktop install: https://docs.docker.com/docker-for-windows/install/

Can you verify that it’s installed?

I also wonder if it might work from a Git Bash shell. Could you try that?

Thanks again!

@kenwrites
Copy link
Contributor

Put in a PR to resolve this Issue: #33

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

2 participants