diff --git a/bridge/bindings/qjs/dom/element.h b/bridge/bindings/qjs/dom/element.h index 3b2335d7ea..b4b8aefbf0 100644 --- a/bridge/bindings/qjs/dom/element.h +++ b/bridge/bindings/qjs/dom/element.h @@ -45,7 +45,6 @@ class SpaceSplitString { std::vector m_szData; }; - // TODO: refactor for better W3C standard support and higher performance. // https://dom.spec.whatwg.org/#interface-namednodemap class NamedNodeMap : public GarbageCollected { diff --git a/bridge/bindings/qjs/dom/style_declaration.cc b/bridge/bindings/qjs/dom/style_declaration.cc index a0bf573274..64bab674a3 100644 --- a/bridge/bindings/qjs/dom/style_declaration.cc +++ b/bridge/bindings/qjs/dom/style_declaration.cc @@ -98,7 +98,6 @@ IMPL_FUNCTION(CSSStyleDeclaration, removeProperty)(JSContext* ctx, JSValue this_ return JS_UNDEFINED; } - IMPL_FUNCTION(CSSStyleDeclaration, getPropertyValue)(JSContext* ctx, JSValue this_val, int argc, JSValue* argv) { if (argc < 1) return JS_ThrowTypeError(ctx, "Failed to execute 'getPropertyValue' on 'CSSStyleDeclaration': 1 arguments required, but only 0 present."); @@ -159,7 +158,6 @@ JSValue StyleDeclaration::getPropertyValue(std::string& name) { return JS_NewString(m_ctx, ""); } - void parseRules(std::string& source, ParseRuleCallback callback, void* context) { uint32_t idx = 0; uint32_t start = idx; @@ -196,7 +194,6 @@ void parseRules(std::string& source, ParseRuleCallback callback, void* context) } void StyleDeclaration::setCssText(std::string& cssText) { - parseRules( cssText, [](void* p, std::string& key, std::string& value) { @@ -264,7 +261,6 @@ JSValue StyleDeclaration::getObjectProperty(JSContext* ctx, JSValue obj, JSAtom return result; } - JSClassExoticMethods StyleDeclaration::m_exoticMethods{ nullptr, nullptr, nullptr, nullptr, nullptr, getObjectProperty, setObjectProperty, }; diff --git a/bridge/bindings/qjs/html_parser.cc b/bridge/bindings/qjs/html_parser.cc index 5221b3b2b8..2a9e7fae89 100644 --- a/bridge/bindings/qjs/html_parser.cc +++ b/bridge/bindings/qjs/html_parser.cc @@ -103,7 +103,7 @@ void HTMLParser::parseProperty(ElementInstance* element, GumboElement* gumboElem for (int j = 0; j < attributes->length; ++j) { auto* attribute = (GumboAttribute*)attributes->data[j] - std::string strName = attribute->name; + std::string strName = attribute->name; std::string strValue = attribute->value; JSValue key = JS_NewString(ctx, strName.c_str());