New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fail a github action when contribution guidelines are not satisfied #183

Open

aarishshahmohsin opened this issue May 6, 2024 · 1 comment

Contributor

aarishshahmohsin commented May 6, 2024 •

edited

Loading

As listed in the contribution guidelines Link:

The branch name should be of the format Software-Discovery-Tool-feature_name.
The commits should include a DCO signoff

A github action should be created that will fail if these conditions are not met.

Please assign this issue to me if it could be a viable addition.

Contributor

pleia2 commented May 6, 2024

It turns out we're not strict on the first one, and it seems a bit frivolous. I'd prefer we update the contribution guidelines to remove it.

The second one already has a check that is required to pass.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment