From 01896ffb954ef3ee9d3930d89acbefc3a4fa3f8b Mon Sep 17 00:00:00 2001
From: Krisztian Gacsal <chrisgacsal@users.noreply.github.com>
Date: Fri, 27 Sep 2024 14:37:23 +0200
Subject: [PATCH 1/2] fix(api): Notification update API
---
api/spec/src/notification/channel.tsp | 2 +-
api/spec/src/notification/rule.tsp | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/api/spec/src/notification/channel.tsp b/api/spec/src/notification/channel.tsp
index 2bb4778bb..441f40ae0 100644
--- a/api/spec/src/notification/channel.tsp
+++ b/api/spec/src/notification/channel.tsp
@@ -197,7 +197,7 @@ interface Channels {
@put
@operationId("updateNotificationChannel")
@summary("Update a notification channel")
- update(@body request: ChannelCreateRequest): {
+ update(@path channelId: ULID, @body request: ChannelCreateRequest): {
@statusCode _: 200;
@body body: Channel;
} | OpenMeter.CommonErrors;
diff --git a/api/spec/src/notification/rule.tsp b/api/spec/src/notification/rule.tsp
index cd11dcf72..e4c086f2e 100644
--- a/api/spec/src/notification/rule.tsp
+++ b/api/spec/src/notification/rule.tsp
@@ -278,7 +278,7 @@ interface Rules {
@put
@operationId("updateNotificationRule")
@summary("Update a notification rule")
- update(@body request: RuleCreateRequest): {
+ update(@path ruleId: ULID, @body request: RuleCreateRequest): {
@statusCode _: 200;
@body body: Rule;
} | OpenMeter.CommonErrors;
From d1b78439dca1d84e96f1b9da9f5d732f6104142b Mon Sep 17 00:00:00 2001
From: Krisztian Gacsal <chrisgacsal@users.noreply.github.com>
Date: Fri, 27 Sep 2024 14:50:32 +0200
Subject: [PATCH 2/2] fix(api): test endpoint for Notification API
---
api/spec/src/notification/rule.tsp | 1 +
1 file changed, 1 insertion(+)
diff --git a/api/spec/src/notification/rule.tsp b/api/spec/src/notification/rule.tsp
index e4c086f2e..2940158c7 100644
--- a/api/spec/src/notification/rule.tsp
+++ b/api/spec/src/notification/rule.tsp
@@ -311,5 +311,6 @@ interface Rules {
@operationId("testNotificationRule")
test(@path ruleId: ULID): {
@statusCode _: 201;
+ @body body: Event;
} | OpenMeter.NotFoundError | OpenMeter.CommonErrors;
}