Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improving dependencies in flows #161

Closed
DraXus opened this issue Nov 26, 2014 · 4 comments
Closed

Improving dependencies in flows #161

DraXus opened this issue Nov 26, 2014 · 4 comments

Comments

@DraXus
Copy link
Collaborator

DraXus commented Nov 26, 2014

Currently, flow dependencies are limited to the software version. However, some of them also require additional dependencies. For example, flow 191 requires also the installation of multiBoostAB from the package manager.

@DraXus
Copy link
Collaborator Author

DraXus commented Nov 26, 2014

From the implementation point of view I don't know how feasible is to know the package of a class in Java though.

@joaquinvanschoren
Copy link
Contributor

You can get the name of a class's package using Java introspection. Only
for classes that are loaded, though.

On Wed Nov 26 2014 at 1:18:58 PM Manuel Martín [email protected]
wrote:

From the implementation point of view I don't know how feasible is to know
the package of a class in Java though.


Reply to this email directly or view it on GitHub
#161 (comment).

@DraXus
Copy link
Collaborator Author

DraXus commented Dec 6, 2014

I did some modifications in the Weka package and I was able to compile it. However, when I install it using the package manager in Weka 3.7.11 it says that it's not compatible. I guess that some black magic is doing behind the scenes to create the current OpenWeka package, so probably additional steps are needed.

Nevertheless, I add here these lines from WekaAlgorithm.create() for my own record :)

Package packageOfClassifier = classifier.getClass().getPackage();
        if (packageOfClassifier!=null){
            dependencies += "; " + packageOfClassifier.toString() + "_" + packageOfClassifier.getImplementationVersion();
        }

@joaquinvanschoren
Copy link
Contributor

This issue was moved to openml/openml-java#12

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants