Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE] Clean up logic behind admin credential changes in 2.12 onwards #764

Open
derek-ho opened this issue Jun 18, 2024 · 0 comments
Open
Labels
enhancement New feature or request

Comments

@derek-ho
Copy link
Contributor

Is your feature request related to a problem?

In #631, logic was introduced in the CI to pass in a different credential based on the version. If the version of opensearch is 2.12 or later, the demo configuration needs a strong password. Prior to that, the defualt "admin" was used. However, this was done in a sub-optimal way, which needed if - else blocks in .sh files. Ideally, this should be done with github env variables (at the top level), with no other changes within the scripting files.

What solution would you like?

Clean up of the conditional code passing in different creds

What alternatives have you considered?

None

Do you have any additional context?

None

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants