-
Notifications
You must be signed in to change notification settings - Fork 293
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FEATURE] Implement SecureAuxTransportSettingsProvider for auxiliary transports #5104
Comments
Hi @rishabhmaurya, |
@finnegancarroll it depends on how we are planning to change Do you see any concerns? |
It seems to me there are two distinct problems:
I like your solution to problem 1 and would like to build on it to address problem 2 by adding a new I think these two solutions are complimentary but let me know your thoughts are about this path forward. |
@finnegancarroll sounds good to me. Do we currently have any additional settings which aux transport might need? If not, we can defer 2. |
Nothing comes to mind. Sounds good. |
Is your feature request related to a problem?
Recently added to core, auxiliary transports are client/server transports which run in parallel to the existing rest api. To implement TLS for these transports they need access to a SecureTransportSettingsProvider as provided by the security plugin.
What solution would you like?
I would propose the security plugin provide a SecureAuxTransportSettingsProvider to be consumed by NetworkPlugins which implement
getAuxTransports()
and configured with settings distinct from its http counterpart (plugins.security.ssl.aux.pemkey_filepath
, ...).What alternatives have you considered?
Have AuxTransports consume the SecureHttpTransportSettingsProvider. I think it makes sense to create an entirely new SettingsProvider because:
HttpServerTransport
contains some rest specific objects.*This could probably be solved with a small refactor?
Additional context
opensearch-project/OpenSearch#16905
opensearch-project/OpenSearch#16787
The text was updated successfully, but these errors were encountered: