Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Several minor issues and fixes #458

Open
pengchuan-lin-bp opened this issue Feb 11, 2023 · 2 comments
Open

Several minor issues and fixes #458

pengchuan-lin-bp opened this issue Feb 11, 2023 · 2 comments

Comments

@pengchuan-lin-bp
Copy link

Hello,

Here are some other minor issues that I encountered while trying out OSS and fixes I used for them.

  1. File system monitoring script uses pyinotify, which doesn't work well with NFS (network file system). I modified src/open-semantic-etl/src/opensemanticetl/etl_filemonitoring.py to use polling observer from watchdog instead, but the drawback is that it will no longer be instantaneous anymore without polling constantly. I also needed to list watchdog as a requirement in src/open-semantic-etl/src/opensemanticetl/requirements.txt.
  2. In the search page, the black tooltip box that shows up while hovering over file path will cut off long file path strings due to max-width configured by .tooltip in src/solr-php-ui/src/css/foundation.css. I added word-break: break-all; so that the tooltip box displays the entire string without any cut off.
  3. In the search page. the sorting option dropdown will have a fourth, repeating option if Newest or Oldest is chosen. I wrapped the last option $sort_other in src/solr-php-ui/src/templates/select_sort.php with <?php if(false): ?> and <?php endif; ?> so that it won't show up anymore.

I hope this can be of help!

@Mandalka
Copy link
Collaborator

Please add a Pullrequest for 2 and one for 3 so i can easier review it and one to add to Contributors in README.md. Sorry not having time for deeper look at 1 these days.

@pengchuan-lin-bp
Copy link
Author

All three pull requests are created. No worries for 1. Since it's NFS specific, I simply wrote it down to help anyone that might need this information.

Thank you for your help!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants