Skip to content
This repository has been archived by the owner on Apr 12, 2022. It is now read-only.

Checks should be chainable based on the outcomes of previous checks #73

Open
SanyaKochhar opened this issue Aug 23, 2021 · 0 comments
Open
Assignees

Comments

@SanyaKochhar
Copy link
Contributor

SanyaKochhar commented Aug 23, 2021

Right now we run all checks in a series, but there could some scenarios where a number of checks preclude each other.

Ex 1: in the osm-health connectivity pod-to-pod command, if we were to add a check for permissive traffic policy mode, any SMI traffic target checks would not be run.

Ex 2: in the same command - if the pods are referenced by a traffic target, could do an additional check to output whether the protocol is tcp or httproute. (that being said, this particular example could be achieved by including the protocol type in the diagnostic info of the check)

I think there are enough cases where adding this additional logic would be beneficial. This would require updating checks to have a distinct output that could be used to preclude other checks being run. Would require some changes to the runner and probably a GetOutcomeType() method added to the outcomes created in #70

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants