Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add initial validators #5

Open
7 of 23 tasks
deads2k opened this issue May 16, 2023 · 3 comments
Open
7 of 23 tasks

Add initial validators #5

deads2k opened this issue May 16, 2023 · 3 comments
Labels
lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness.

Comments

@deads2k
Copy link
Contributor

deads2k commented May 16, 2023

  • don't use bools
  • don't use maps
  • don't use floats
  • don't use unsigned ints
  • no new fields can be required
  • don't remove fields
  • don't change field types
  • don't tighten validation rules
  • don't loosen validation rules (warning)
  • status subresource must be used if status exists
  • conditions must match metav1.Conditions with proper SSA tags
  • all lists must have SSA tags
  • no durations (for kube, openshift configuration API allowed)
  • enumerated values should use CamelCase
  • optional should be pointers (for kube, openshift configuration API allowed)
  • defaulted values have to be optional to pass CR validation
  • stable versions cannot coexist with unstable versions
  • booleans cannot be defaulted
  • no uses of corev1.ObjectReference
  • no uses of corev1.LocalObjectReference
  • no new enumerated values (warning)
  • no removed enumerated values (error)
  • no replace in list (warning)
@pgodowski
Copy link

I see the list is a combination of strict rules and some are more like guidances, like enumerated values should use CamelCase - I don't see why would this matter, for the CRD compatibility?

@openshift-bot
Copy link

Issues go stale after 90d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.
Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle stale

@openshift-ci openshift-ci bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Aug 30, 2023
@deads2k
Copy link
Contributor Author

deads2k commented Sep 15, 2023

/lifecycle frozen

still working through.

@openshift-ci openshift-ci bot added lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Sep 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness.
Projects
None yet
Development

No branches or pull requests

3 participants