IBI Config image does not include .json files from the extra-manifests directory

[xphyr]

Version

$ openshift-install version
openshift-install417 4.17.0-rc.5
built from commit dfd4c085a7210e49111fa8d6747016d78f98ecf2
release image quay.io/openshift-release-dev/ocp-release@sha256:5b1399dc8175d7d26611c2541962d101948cba6a951ed3dd51cddf75afbab303

Platform:

baremetal

• IBI (Image Based Installer)

What happened?

When creating an IBI Config image, that contains an extra-manifests directory, .json files are ignored and not added to the config ISO.

What you expected to happen?

All appropriate configuration files including YAML, YML and JSON should be included and applied at configuration time.

How to reproduce it (as minimally and precisely as possible)?

1. create install directory with a subdirectory of extra-manifests
2. copy in a install-config.yaml and image-based-config.yaml file to the install directory
3. create a test.yaml and test.json and place in install\extra-manifests
4. run openshift-install417 image-based create config-image --dir install/
5. review the contents of the install/imagebasedconfig.iso and find that test.json is NOT included in extra-manifests on the ISO image

Anything else we need to know?

The problem exists here: https://github.com/openshift/installer/blob/master/pkg/asset/imagebased/configimage/extramanifests.go#L42

I am working on a PR now that addresses this issue, and will submit it later today. I will be sure to reference this issue in the PR request.

References