Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add date restriction #6

Open
dmecke opened this issue Apr 7, 2015 · 3 comments
Open

add date restriction #6

dmecke opened this issue Apr 7, 2015 · 3 comments

Comments

@dmecke
Copy link

dmecke commented Apr 7, 2015

Hi and thanks a lot for your lib!

Are you planning to add an additional restriction "date" to enable users to activate a feature based on a given date? Or are you willing to accept a pull request that offers this?

If so, how should it be combinable with the others? As far as I understand, at the moment all restrictions are or-connected, so if you are either in the percentage OR your user is active OR you are in a specified group, you get the feature. Should a date restriction enable it for everyone, regardless of their state? That would be more consistent, though it would also be nice to be able to plan a "softlaunch" for only a given percentage for example.

@richardfullmer
Copy link
Contributor

Are you planning to add an additional restriction "date" to enable users to activate a feature based on a given date?

Don't have current plans for this at the moment. We're primarily using this with a bundle in one of our SF2 applications and turn the features on and off when we need them.

Or are you willing to accept a pull request that offers this?

Potentially, if it were well thought out and use cases detailed well. There is an advantage to staying somewhat close to the project this was ported from. That being said, I haven't stayed up to date with improvements they've been making since I did the port.

@dmecke
Copy link
Author

dmecke commented Apr 7, 2015

I use the bundle as well, so toggling it manually is an option of course. Though it would be convenient to have some features being switched on or off at a scheduled date automatically.

@richardfullmer
Copy link
Contributor

If you're willing to define the dates in code, you could potentially use a group to do the work, but I recognize that's probably not the best option...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants