Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove KOLLA_COPY_STRATEGY as COPY_ALWAYS is the default now #707

Closed
gibizer opened this issue Feb 26, 2024 · 1 comment · May be fixed by #807
Closed

Remove KOLLA_COPY_STRATEGY as COPY_ALWAYS is the default now #707

gibizer opened this issue Feb 26, 2024 · 1 comment · May be fixed by #807
Assignees
@mrkisaolamb

Comments

@gibizer
Copy link
Contributor

gibizer commented Feb 26, 2024 

          this is a point of divergance form kolla

they removed this since COPY_ALWAYS was the default and no one used
COPY_ONCE so we probably should do that eventually.

this is not wrong its just unnecessary for us to support anything else in tcib.

https://github.com/openstack-k8s-operators/tcib/blob/main/container-images/kolla/base/set_configs.py#L371-L386 can be simplified

Originally posted by @SeanMooney in #698 (comment)
@gibizer gibizer changed the title Remove KOLLA_COPY_STRATEGY as COPY_ALWAYS Remove KOLLA_COPY_STRATEGY as COPY_ALWAYS is the default now Feb 26, 2024
@gibizer gibizer mentioned this issue Feb 26, 2024
Merged
@mrkisaolamb mrkisaolamb self-assigned this Jun 28, 2024
@mrkisaolamb mrkisaolamb mentioned this issue Jun 28, 2024
Open
@gibizer
Copy link
Contributor Author

gibizer commented Aug 28, 2024

It is now tracked in https://issues.redhat.com/browse/OSPRH-9742

@gibizer gibizer closed this as completed Aug 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mrkisaolamb mrkisaolamb

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Remove KOLLA_COPY_STRATEGY as COPY_ALWAYS is the default now mrkisaolamb/nova-operator
2 participants
@gibizer @mrkisaolamb