-
Notifications
You must be signed in to change notification settings - Fork 927
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change naming of boundaries based on admin_level=* #5450
Comments
Well the fundamental problem is that the numeric admin_level tagging scheme is, and always has been, totally insane and just doesn't work in the real world. There isn't much we as web site developers can do about that though. Probably we should ignore admin_level and just label them all as administrative boundaries - it makes as much if not more sense as trying to divide them into regional, local and sublocal (whatever sublocal is other than not being an english word). |
Even the numbering in admin_level is better than no information at all, as it at least gives a ballpark for comparing admin boundaries between each other. Remember that osm.org is useful for mapper feedback first and foremost: Plenty of places have admin boundaries with the exact same name that contain each other. For example, the boundary for the settlement of Groningen, Groningen's municipality and Groningen's province, are all simply name=Groningen. Simply wiping the slate clean would make distinguishing between these cases a hassle (currently they are labelled as Suburb Boundary, City Boundary, and State Boundary respectively in case you were wondering). |
For Overpass queries, there’s currently a special case that pulls in a dedicated string based on the openstreetmap-website/app/assets/javascripts/index/query.js Lines 73 to 78 in 7565f5a
Maybe instead we could use the generic “Administrative Boundary” label, using the normal code path, but add a suffix like “(Level 3)”? I shied away from numbers in #5029 (comment) because terms like “second-order administrative subdivision” exist in the real world, and the numbers don’t ever mean what they do in OSM. But if we separate it from the prefix as a parenthetical, then I think it’ll look like a piece of OSM-specific metadata. For Nominatim queries, if a openstreetmap-website/app/controllers/geocoder_controller.rb Lines 101 to 107 in 7565f5a
For example, searching for “Wapakoneta” returns this I think it would be possible to use a suffix here too. It would need some additional translatable format strings. |
The |
Fortunately, Nominatim does expose Unfortunately, Fortunately, the Nominatim result comes with a Unfortunately, the Overpass queries execute independently of each other, so the results for nearby features won’t have any context about the containing country. Since the response is handled on the client side in JavaScript, we could parse the enclosing features results for a country boundary, whenever it arrives, and patch up the labels on the enclosing features. In the meantime, these labels would use the global strings. Kind of icky, but I guess it could work. |
#5493 implements the enhancements above except for distinguishing a given |
Problem
As discussed in this forum thread the current naming scheme for boundaries is a peculiar mishmash of terminology from different English speaking countries that actually applies to none at all. This not only results in weird names for boundaries in English, but inconsistency in translation of the website, as some communities try to rectify this on their own, or have conflicting translations for English terminology.
Description
I propose that these are reverted to generic terminology, perhaps based on pure admin_level number, until a more appropriate solution on a per country basis can be implemented. Minh Nguyen has proposed one such solution, albeit as part of his larger proposal to convert the site to American English by default, with which I disagree.
Screenshots
No response
The text was updated successfully, but these errors were encountered: