Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Selecting a note centres the map on it and zooms #5683

Closed
ntaulbut opened this issue Feb 15, 2025 · 4 comments · Fixed by #5686
Closed

Selecting a note centres the map on it and zooms #5683

ntaulbut opened this issue Feb 15, 2025 · 4 comments · Fixed by #5686

Comments

@ntaulbut
Copy link

ntaulbut commented Feb 15, 2025

Problem

Recently a behaviour was introduced where selecting a note centres the map on the note, and zooms to a certain level. This is a problem because:

  1. We may be zoomed in when selecting a note, and we don't want to be taken out of the area we were focusing on.
  2. Similarly when zoomed far out we don't want to be zoomed in.
  3. This is especially noticeable if we want to browse several notes, because the map will keep moving as we select each one, which is distracting and we have to keep re-orientating ourselves.
  4. The map flashes each time we select a note.
  5. Without a note selected, after refreshing the page (or after first opening it), this issue does not occur for the first note I click on. It happens on all subsequent occasions. It always occurs if loaded with a note selected.

Description

The previous behaviour where the map does not move or zoom when selecting a note should be restored.

Videos

2025-02-15.19-41-58.mp4
@ntaulbut ntaulbut changed the title Selecting a note centres the map on it and zooms out Selecting a note centres the map on it and zooms Feb 15, 2025
@danieldegroot2
Copy link
Contributor

danieldegroot2 commented Feb 15, 2025

This issue might be a regression from #5679.

Sidenote: It has similar behavior to #648.

@ntaulbut
Copy link
Author

This issue might be a regression from #5679.

Looks like it.

@matkoniecz
Copy link
Contributor

@tyrasd Is it intentional that clicking on note zooms you out?

@tyrasd
Copy link
Member

tyrasd commented Feb 16, 2025

sorry, this was an unintended side effect of #5679. working on a fix now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants