Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable SDK errors to be testable #1676

Open
jrschumacher opened this issue Oct 23, 2024 · 0 comments
Open

Enable SDK errors to be testable #1676

jrschumacher opened this issue Oct 23, 2024 · 0 comments
Labels
comp:sdk A software development kit, including library, for client applications and inter-service communicati

Comments

@jrschumacher
Copy link
Member

Many of the SDK errors are not testable with errors.Is() and not usable for exact unit test assertions without string comparisons.

Acceptance Criteria

  • replace all errors with a defined error
  • replace any %w with errors.Join()
jrschumacher added a commit that referenced this issue Oct 23, 2024
@jrschumacher
feat(sdk): enable SDK errors to be testable
7e62774 
Expose errors as variables so they can be tested with `errors.Is()`.
Ensure errors are in a single file for DX maintenance with regards to grammar and support.

Close #1676
@jrschumacher jrschumacher mentioned this issue Oct 23, 2024
Closed
@jrschumacher jrschumacher added the comp:sdk A software development kit, including library, for client applications and inter-service communicati label Jan 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
comp:sdk A software development kit, including library, for client applications and inter-service communicati
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(sdk): enable SDK errors to be testable opentdf/platform
1 participant
@jrschumacher