Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

set_coldkeypub arguments passed in wrong order #51

Open
adal-chiriliuc-reef opened this issue Oct 13, 2024 · 0 comments
Open

set_coldkeypub arguments passed in wrong order #51

adal-chiriliuc-reef opened this issue Oct 13, 2024 · 0 comments

Comments

@adal-chiriliuc-reef
Copy link

adal-chiriliuc-reef commented Oct 13, 2024

Method called with overwrite=overwrite, encrypt=false, but the method accepts these two arguments in the other order - encrypt first, then overwrite:

https://github.com/opentensor/btwallet/blob/main/src/wallet.rs#L831

self.set_coldkeypub(keypair, overwrite, false, py)?;

https://github.com/opentensor/btwallet/blob/main/src/wallet.rs#L515-L521

pub fn set_coldkeypub(
    &mut self,
    keypair: Keypair,
    encrypt: bool,
    overwrite: bool,
    py: Python,
) -> PyResult<()> {
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant