From 3b1352dafddff722709524166223484f5ad5f6bf Mon Sep 17 00:00:00 2001 From: Keith Date: Thu, 25 Jul 2024 16:55:52 +0200 Subject: [PATCH 1/4] Only run spec version check when the skip label doesn't exist --- .github/workflows/check-finney.yml | 1 + 1 file changed, 1 insertion(+) diff --git a/.github/workflows/check-finney.yml b/.github/workflows/check-finney.yml index 4bb12caf2..2428487b7 100644 --- a/.github/workflows/check-finney.yml +++ b/.github/workflows/check-finney.yml @@ -11,6 +11,7 @@ jobs: check-spec-version: name: Check spec_version bump runs-on: SubtensorCI + if: !contains(github.event.issue.labels.*.name, 'no-spec-version-bump') steps: - name: Dependencies run: | From 58cc59b8f2f482243305f233677949510e11fef0 Mon Sep 17 00:00:00 2001 From: Keith Date: Thu, 25 Jul 2024 17:01:01 +0200 Subject: [PATCH 2/4] Fix syntax error --- .github/workflows/check-finney.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/check-finney.yml b/.github/workflows/check-finney.yml index 2428487b7..ac14dd601 100644 --- a/.github/workflows/check-finney.yml +++ b/.github/workflows/check-finney.yml @@ -11,7 +11,7 @@ jobs: check-spec-version: name: Check spec_version bump runs-on: SubtensorCI - if: !contains(github.event.issue.labels.*.name, 'no-spec-version-bump') + if: ${{ !contains(github.event.issue.labels.*.name, 'no-spec-version-bump') }} steps: - name: Dependencies run: | From 31d6fe3512048deb81edd8ac79a9f49f2653dee6 Mon Sep 17 00:00:00 2001 From: Keith Date: Tue, 30 Jul 2024 23:22:45 +0900 Subject: [PATCH 3/4] Fix syntax --- .github/workflows/check-finney.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/check-finney.yml b/.github/workflows/check-finney.yml index ac14dd601..3e9fb5994 100644 --- a/.github/workflows/check-finney.yml +++ b/.github/workflows/check-finney.yml @@ -11,7 +11,7 @@ jobs: check-spec-version: name: Check spec_version bump runs-on: SubtensorCI - if: ${{ !contains(github.event.issue.labels.*.name, 'no-spec-version-bump') }} + if: ${{ !contains(github.event.pull_request.labels.*.name, 'no-spec-version-bump') }} steps: - name: Dependencies run: | From f212a59371ade5bdbd18d6870e98cdc1a063ca7a Mon Sep 17 00:00:00 2001 From: Keith Date: Wed, 31 Jul 2024 00:41:09 +0900 Subject: [PATCH 4/4] Fix clippy --- pallets/collective/src/lib.rs | 1 + 1 file changed, 1 insertion(+) diff --git a/pallets/collective/src/lib.rs b/pallets/collective/src/lib.rs index 96040f99c..66c55036d 100644 --- a/pallets/collective/src/lib.rs +++ b/pallets/collective/src/lib.rs @@ -951,6 +951,7 @@ impl, I: 'static> Pallet { /// /// If not `approved`: /// - one event deposited. + /// /// Two removals, one mutation. /// Computation and i/o `O(P)` where: /// - `P` is number of active proposals