Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Good First Issue][NNCF][TorchFX]: Test statistic aggregator #2777

Closed
daniil-lyakhov opened this issue Jul 1, 2024 · 5 comments
Closed

[Good First Issue][NNCF][TorchFX]: Test statistic aggregator #2777

daniil-lyakhov opened this issue Jul 1, 2024 · 5 comments
Assignees
@rk119
Labels
good first issue Good for newcomers

Comments

@daniil-lyakhov
Copy link
Collaborator

daniil-lyakhov commented Jul 1, 2024 •
edited
Loading

Greetings🐱! As a part of #2766 TorchFX PTQ backend support, we are gladly presenting to you following issue

Context

Implement TemplateTestStatisticsAggregator as it done for other backends (example: https://github.com/openvinotoolkit/nncf/blob/develop/tests/torch/test_statistics_aggregator.py)

What needs to be done?

  • TemplateTestStatisticsAggregator test class implementation for the TorchFX PTQ backend in tests/torch_fx/test_statistics_aggregator.py file

Example Pull Requests

No response

Resources

Contact points

@daniil-lyakhov

Ticket

141640
@daniil-lyakhov daniil-lyakhov added the good first issue Good for newcomers label Jul 1, 2024
@github-project-automation github-project-automation bot moved this to Contributors Needed in Good first issues Jul 1, 2024
@anzr299
Copy link
Contributor

anzr299 commented Jul 25, 2024

@rk119

@rk119
Copy link
Contributor

rk119 commented Jul 25, 2024

.take

@github-actions GitHub Actions
Copy link

Thank you for looking into this issue! Please let us know if you have any questions or require any help.

@alexsu52 alexsu52 moved this from Contributors Needed to Assigned in Good first issues Jul 26, 2024
@rk119 rk119 mentioned this issue Jul 30, 2024
Merged
@rk119
Copy link
Contributor

rk119 commented Jul 30, 2024

@daniil-lyakhov I have created a PR #2856 for this issue.

AlexanderDokuchaev pushed a commit that referenced this issue Jul 31, 2024
@rk119
[Torch Fx] Statistics Aggregator test (#2856)
02c9b53 
### Changes

New test file for the statistics aggregator for the TorchFX backend has
been added in tests/torch/fx.

### Related tickets

Closes Issue #2777
@daniil-lyakhov
Copy link
Collaborator Author

@rk119, thank you for the contribution!

@github-project-automation github-project-automation bot moved this from Assigned to Closed in Good first issues Jul 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rk119 rk119

Labels
good first issue Good for newcomers
Projects
Good first issues
Archived in project
Milestone
No milestone
Development

No branches or pull requests
3 participants
@anzr299 @daniil-lyakhov @rk119