Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[TorchFX] TorchFX metatypes support #2778

Closed
1 task
daniil-lyakhov opened this issue Jul 1, 2024 · 2 comments
Closed
1 task

[TorchFX] TorchFX metatypes support #2778

daniil-lyakhov opened this issue Jul 1, 2024 · 2 comments
Assignees
@anzr299
Labels
enhancement New feature or request

Comments

@daniil-lyakhov
Copy link
Collaborator

daniil-lyakhov commented Jul 1, 2024 •
edited
Loading

🚀 Feature request

The task is to

  • Map following types to a metatypes: index, linalg_vector_norm, clamp_min, clamp
  • Add nncf graph tests to cover nncf graph building for target models scope: resnet18, mobilenet_v3_small, vit_b_16, swin_v2_s (from Torchvision), YoloV8(from ultralytics)

#2764

Feature Use Case

To enable PTQ quantization for torch.fx.GrpaphModule models

Are you going to submit a PR?

  • Yes I'd like to help by submitting a PR!
@daniil-lyakhov daniil-lyakhov added the enhancement New feature or request label Jul 1, 2024
@anzr299
Copy link
Collaborator

anzr299 commented Jul 4, 2024

.take

@github-actions GitHub Actions
Copy link

github-actions bot commented Jul 4, 2024

Thank you for looking into this issue! Please let us know if you have any questions or require any help.

This was referenced Jul 8, 2024
Closed
Merged
alexsu52 pushed a commit that referenced this issue Jul 30, 2024
@anzr299 @daniil-lyakhov
[TorchFX] Graph/metatypes tests implementation (#2796)
25eff06 
### Changes

1. Added pytest to check if all the ops in the generated graph for
resnet18, mobilenet_v3_small, vit_b_16, swin_v2_s and yolov8n models
have valid metatypes in NNCF
2. Added pytest to check if the generated NNCF graph for resnet18,
mobilenet_v3_small, vit_b_16, swin_v2_s and yolov8n match with reference
graphs. (tests/torch/fx/test_models.py)
3. Add metatype mapping for the following:
 - linalg_vector_norm
 - clamp
 - clamp_min
 - hardswish_
 - dropout_

### Reason for changes

Check if all model ops are supported by NNCF metatypes

### Related tickets

#2778

### Tests

New test file test_models.py added in tests/torch/fx/test_models.py

---------

Co-authored-by: dlyakhov <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@anzr299 anzr299

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@anzr299 @daniil-lyakhov