Added Relevant support for aten::quantile and it's tests. #28599
+118
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
category: CPU
|
build_jenkins |
|
@rkazants |
|
build_jenkins |
|
@rkazants could you please guide me out what are the issues |
|
Hello @geeky33, there seems to be a number of build errors, as seen in the CI logs. Do you have access to them? [2025-02-04T08:29:32.314Z] [2025-02-04 08:29:21,392] [140520036398848] build ie ERROR: ========== ERRORS were found in the output:
[2025-02-04T08:29:32.314Z] [2025-02-04 08:29:21,392] [140520036398848] build ie ERROR: ../../repos/openvino/src/frontends/pytorch/src/op/quantile.cpp:78:1: error: expected declaration before ‘}’ token
[2025-02-04T08:29:32.314Z] [2025-02-04 08:29:21,392] [140520036398848] build ie ERROR: ../../repos/openvino/src/frontends/pytorch/src/op/quantile.cpp:77:1: error: expected declaration before ‘}’ token
[2025-02-04T08:29:32.315Z] [2025-02-04 08:29:21,392] [140520036398848] build ie ERROR: ../../repos/openvino/src/frontends/pytorch/src/op/quantile.cpp:21:1: error: ‘OutputVector’ does not name a type
[2025-02-04T08:29:32.315Z] [2025-02-04 08:29:21,392] [140520036398848] build ie ERROR: FAILED: src/frontends/pytorch/src/CMakeFiles/openvino_pytorch_frontend.dir/op/quantile.cpp.o
[2025-02-04T08:29:32.315Z] [2025-02-04 08:29:21,392] [140520036398848] build ie ERROR: ../../repos/openvino/src/frontends/pytorch/src/op/quantile.cpp:80:1: error: expected declaration before ‘}’ token
[2025-02-04T08:29:32.315Z] [2025-02-04 08:29:21,392] [140520036398848] build ie ERROR: ../../repos/openvino/src/frontends/pytorch/src/op/quantile.cpp:79:1: error: expected declaration before ‘}’ token |
mvafin
requested changes
Feb 6, 2025
| @@ -747,6 +748,7 @@ const std::unordered_map<std::string, CreatorFunction> get_supported_ops_ts() { | |||
| {"quantized::hardswish", op::translate_quantized_hardswish}, | |||
| {"quantized::linear", op::translate_quantized_linear}, | |||
| {"quantized::mul", op::translate_quantized_mul}, | |||
| {"quantized::relu", op::translate_quantile}, | |||
There was a problem hiding this comment.
Suggested change
| {"quantized::relu", op::translate_quantile}, | |
| {"aten::quantile", op::translate_quantile}, |
| #include "openvino/op/maximum.hpp" | ||
| #include "openvino/op/minimum.hpp" | ||
| #include "utils.hpp" | ||
|
|
There was a problem hiding this comment.
Suggested change
| namespace ov { | |
| namespace frontend { | |
| namespace pytorch { | |
| namespace op { | |
You forgot to open namespaces
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Details:
Added aten::quantile
Made the changes in the relevant files and added two files by taking the relevant information from the documentation mentioned in the Issue.
Implemented conversion rule and/or transformation to support the new operation.
Implement operation tests in tests/layer_tests/pytorch_tests. Please consider different data types, but keep reasonable number of test cases.*
Communicated with @andrei-kochin Sir for the permission to make the pull request. Kindly consider the PR. :)
Tickets: