-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Active Drive] Max fragment size must be under 1MB when using ADs #464
Comments
Can we combine this with #204 ?
Note that the API should have the same checks. |
This becomes obsolete if the AD supports higher fragment sizes. Let's keep on hold for now hence assigning to me. |
mind, compression can increase the size of a fragment. |
Sure but to me that isn't a framework problem but more of an ALBA problem as ALBA knows when it goes above the fragment size limit and should act accordingly. |
This could indeed be solved inside alba too.
|
or calculate a fragment size depending on the preset. We know the maximum fixed cost of a compressor, so if a compressor is used, the |
To me it looks like the solution of @toolslive would be the easiest to implement? Also this boils down to 2 scenarios:
|
who does the calculation / when does the calculation happen in @toolslive suggestion? |
I don't see where the framework would be involved in this. ALBA get a preset including max fragment size and whether or not compression is set. It is up to ALBA to take the necessary cost into account. |
It should be done during upload. Basically, my suggestion is to redefine/reinterpret the fragment size in |
Back to BAM: Anything to do for framework team? |
After discussion with @toolslive , no need for the framework team to take action as this will be covered by the ALBA team during upload (integration part of the AD). |
Problem description
According to @toolslive, the max fragment size on a preset has to be toned down when using adding an active drive
Todos for the fwk:
The text was updated successfully, but these errors were encountered: