Suggestion for improvement in switch menu

[siegfriedhoellrigl1]

It would be very nice if we could have a "Comment" field for each port under :
Network - Switch menu.

[systemcrash]

What fields do you see today?

[siegfriedhoellrigl1]

Today I can only make comments for the VLANs.
Not for the physical Ports.

[dannil]

Which device are you running? The Network -> Switch menu isn't present on targets which has migrated to DSA (Distributed Switch Architecture), so if we want to have a place to make comments like this regarding the physical ports it should probably not be there, see https://github.com/openwrt/luci/blob/master/modules/luci-mod-network/root/usr/share/luci/menu.d/luci-mod-network.json#L11-L12

[siegfriedhoellrigl1]

At the moment I am using 3 TP-Links :
Archer A7 v5
TL-WDR4300 v1
TL-WR1043ND v2.
So you think, this is useless, because the switch menu will disappear in a short time, correct ?

[dannil]

At the moment I am using 3 TP-Links : Archer A7 v5 TL-WDR4300 v1 TL-WR1043ND v2. So you think, this is useless, because the switch menu will appear in a short time, correct ?

Maybe not useless, some devices will probably never get DSA and stay on swconfig, so for them the switch menu would still appear. But, if we're thinking of a general solution about being able to add comments to the physical ports, there maybe could be a nice solution that would incorporate both swconfig and DSA targets.

EDIT: I took a look at all your listed devices and they're all part of ath79 and that target still uses swconfig, which is why you can still see and use the switch menu component. For example, on my Netgear R7800 I can't see it since it's part of ipq806x, which has migrated to DSA.

[systemcrash]

Admittedly, it's harmless to have a comment field, since it's only ever used in the GUI here. Lower level scripts aren't looking for it. DSA stuff is under Interfaces, right?

[dannil]

Admittedly, it's harmless to have a comment field, since it's only ever used in the GUI here. Lower level scripts aren't looking for it. DSA stuff is under Interfaces, right?

Yes, for example VLAN:s are configured as a new device under interfaces with DSA. If moving this to some "common" place (it would maybe even need a new UI) is too hard I'm fine with just adding a comment field as well.