Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EAD labels > 23 are misencoded, discarding criticality #329

Open
chrysn opened this issue Jan 16, 2025 · 0 comments
Open

EAD labels > 23 are misencoded, discarding criticality #329

chrysn opened this issue Jan 16, 2025 · 0 comments

Comments

@chrysn
Copy link
Collaborator

chrysn commented Jan 16, 2025

I think that the only label/criticality combinations that are currently encoded right are ([1..23], false).

While the decoder properly distinguishes between u8 and i8 values, and can at least decode the simple ones right. However, encoding 25 results in a parser error later.

[edit:] Adding some context: Imlpementing draft-ietf-ace-edhoc-oscore-profile-06, I have to use some value for the "ACE-OAuth Access Token" item. As no early allocation is happening yet, I'll have to make a guess, and I'd have guessed 25. I guess I'll update my guess to 20.

CC'ing @malishav who is DE for that registry and may want to earmark something.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant